Skip to content

Change : handle invalid invite error #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2025
Merged

Change : handle invalid invite error #4909

merged 4 commits into from
Jun 20, 2025

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jun 20, 2025

Content

What the title says.

Motivation and context

See https://github.com/element-hq/customer-success/issues/331#issuecomment-2760630276

Screenshots / GIFs

See recorded screenshots

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Change For updates to an existing feature labels Jun 20, 2025
@ganfra ganfra marked this pull request as ready for review June 20, 2025 14:43
@ganfra ganfra requested a review from a team as a code owner June 20, 2025 14:43
@ganfra ganfra requested review from jmartinesp and removed request for a team June 20, 2025 14:43
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 20, 2025
jmartinesp
jmartinesp approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bRT77U

@ganfra ganfra enabled auto-merge June 20, 2025 15:06
bmarty
bmarty reviewed Jun 20, 2025
View reviewed changes
libraries/ui-strings/src/main/res/values/localazy.xml
@@ -333,6 +333,7 @@ Are you sure you want to continue?"</string>
<string name="error_failed_loading_messages">"Failed loading messages"</string>
<string name="error_failed_locating_user">"%1$s could not access your location. Please try again later."</string>
<string name="error_failed_uploading_voice_message">"Failed to upload your voice message."</string>
<string name="error_invalid_invite">"The room no longer exists or the invite is no longer valid."</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this string in a preview please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am blind, just ignore this!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.76923% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.30%. Comparing base (3a2e36b) to head (c857f7a).
Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
...libraries/matrix/impl/room/join/DefaultJoinRoom.kt 14.28% 6 Missing ⚠️
...ement/android/features/invite/impl/AcceptInvite.kt 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4909      +/-   ##
===========================================
- Coverage    80.30%   80.30%   -0.01%     
===========================================
  Files         2155     2156       +1     
  Lines        57305    57345      +40     
  Branches      7220     7224       +4     
===========================================
+ Hits         46020    46051      +31     
- Misses        8836     8845       +9     
  Partials      2449     2449

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ganfra ganfra merged commit 0a4d32f into develop Jun 20, 2025
30 of 31 checks passed
@ganfra ganfra deleted the feature/fga/invalid-invite branch June 20, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty left review comments

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
PR-Change For updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganfra @jmartinesp @bmarty @ElementBot