Skip to content

Room debug info #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2025
Merged

Room debug info #4904

merged 5 commits into from
Jun 20, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 20, 2025

Content

When developer mode is enabled, render the roomId in the room detail screen. Clicking on the new item copies the room Id to the clipboard.

Motivation and context

Help debug rooms.

Screenshots / GIFs

image

Inspired from Element Web:

image ## Tests
  • Enable developer mode
  • navigate to a room detail
  • observe at the bottom the new item with the roomId

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner June 20, 2025 08:17
@bmarty bmarty requested review from jmartinesp and removed request for a team June 20, 2025 08:17
@bmarty bmarty added the PR-Misc For other changes label Jun 20, 2025
Copy link
Contributor

github-actions bot commented Jun 20, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MKLDPE

Copy link

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.31%. Comparing base (3a2e36b) to head (4161888).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/features/roomdetails/impl/RoomDetailsView.kt 83.33% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4904   +/-   ##
========================================
  Coverage    80.30%   80.31%           
========================================
  Files         2155     2155           
  Lines        57305    57331   +26     
  Branches      7220     7221    +1     
========================================
+ Hits         46020    46043   +23     
- Misses        8836     8839    +3     
  Partials      2449     2449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit a20af86 into develop Jun 20, 2025
30 of 31 checks passed
@bmarty bmarty deleted the feature/bma/roomDebugInfo branch June 20, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants