Skip to content

fix (join room) : do not navigate up when join is successful #4899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jun 19, 2025

Content

Quick fix on the RoomFlow navigation, probably introduced when using the new Flow<RoomInfo> logic.

The membership is observed by the parent RoomFlowNode which take care of attaching the proper Node as a root, so no need to navigateUp in this case.

Motivation and context

Fix issue.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added the PR-Bugfix For bug fix label Jun 19, 2025
@ganfra ganfra marked this pull request as ready for review June 19, 2025 09:29
@ganfra ganfra requested a review from a team as a code owner June 19, 2025 09:29
@ganfra ganfra requested review from jmartinesp and removed request for a team June 19, 2025 09:29
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/paLX6K

Copy link

@ganfra ganfra enabled auto-merge June 19, 2025 09:50
@ganfra ganfra merged commit 802e1d2 into develop Jun 19, 2025
36 of 37 checks passed
@ganfra ganfra deleted the feature/fga/fix_join_room_navigation branch June 19, 2025 09:51
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.30%. Comparing base (680b63d) to head (106a0bf).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4899   +/-   ##
========================================
  Coverage    80.30%   80.30%           
========================================
  Files         2155     2155           
  Lines        57261    57261           
  Branches      7220     7220           
========================================
  Hits         45982    45982           
  Misses        8830     8830           
  Partials      2449     2449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants