fix (event action): allow to edit only if permission to send message #4895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
reviewed
Jun 18, 2025
Comment on lines
551
to
552
| // val loadingState = awaitItem() | ||
| // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent)) |
jmartinesp
approved these changes
Jun 18, 2025
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
ganfra
force-pushed
the
feature/fga/can-edit-permission
branch
from
2273fe8 to
713bae0
Compare
|
|
Previously, was an edit made in this manner discarded, or does this PR remove functionality that used to be available, even if it didn't per se make sense to exist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
What the title says.
Motivation and context
Improve experience.
Screenshots / GIFs
Tests
Tested devices
Checklist