a11y: improve accessibility on rich text editor options. #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4886 +/- ##
========================================
Coverage 80.27% 80.28%
========================================
Files 2148 2148
Lines 57045 57067 +22
Branches 7185 7189 +4
========================================
+ Hits 45793 45816 +23
Misses 8811 8811
+ Partials 2441 2440 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmartinesp
reviewed
Jun 16, 2025
| interactionSource = remember { MutableInteractionSource() }, | ||
| indication = ripple( | ||
| bounded = false, | ||
| radius = 20.dp, | ||
| ), | ||
| ) | ||
| .size(48.dp) | ||
| .then( | ||
| if (toggleable) { | ||
| Modifier.toggleable( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Ensure that talkback (aka screen reader) give the state of the various rich text editor option. The state can be disabled, selected, or not selected, depending on the type of formatting option.
Motivation and context
Improve accessibility of the rich text editor.
Note: iOS PR is element-hq/element-x-ios#4194, but we do not need to use the strings created there, we can use the facilities provided by the compose framework instead.
Screenshots / GIFs
Tests
Tested devices
Checklist