Skip to content

A11Y: improve accessibility on event reactions. #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 13, 2025

Content

Build a text to be read by the screen reader when a reaction on a message is focused. Also tweak the label of the click button.

The following sentences can be read when a reaction is selected under a message:

  • 1 member reacted with [emoji]. Double tap to react with [emoji]
  • [nb] members reacted with [emoji]. Double tap to react with [emoji]
  • You reacted with [emoji]. Double tap to remove reaction with [emoji]
  • You and 1 member reacted with [emoji]. Double tap to remove reaction with [emoji]
  • You and [nb] members reacted with [emoji]. Double tap to remove reaction with [emoji]

With:

  • [nb] is the number of members who reacted using the same emoji.
  • emoji can be the emoji, for instance "thumb up" or "an image" for special case where an image has been used to react (text starting with mxc://)

Motivation and context

Improve accessibility of the application

Screenshots / GIFs

Tests

  • Enable screen reader
  • In a timeline, add a reaction to a message
  • observe how the screen reader handles the reaction.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner June 13, 2025 15:05
@bmarty bmarty requested review from ganfra and removed request for a team June 13, 2025 15:05
@bmarty bmarty added the PR-Misc For other changes label Jun 13, 2025
Copy link
Contributor

github-actions bot commented Jun 13, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7EMAg9

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (c598b06) to head (dbd0e4a).
Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
...eatures/messages/impl/actionlist/ActionListView.kt 71.42% 2 Missing ⚠️
.../features/messages/impl/timeline/a11y/Reactions.kt 91.66% 1 Missing and 1 partial ⚠️
...impl/timeline/components/MessagesReactionButton.kt 90.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4877   +/-   ##
========================================
  Coverage    80.26%   80.27%           
========================================
  Files         2140     2141    +1     
  Lines        56961    57017   +56     
  Branches      7171     7176    +5     
========================================
+ Hits         45721    45771   +50     
- Misses        8805     8810    +5     
- Partials      2435     2436    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@bmarty bmarty merged commit 564beb3 into develop Jun 16, 2025
33 of 34 checks passed
@bmarty bmarty deleted the feature/bma/a11yReactions branch June 16, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants