Skip to content

misc (matrix) : use innerClient.subscribeToRoomInfo sdk method #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jun 6, 2025

Content

Rework how we manage the client.roomInfoFlow by using the new innerClient.subscribeToRoomInfo sdk method.
Ensure we are using only RoomInfo and not RoomSummary as those ones are bound to the RoomList.

Motivation and context

Makes sure we can observe RoomInfo for any room, either a known or unknown room, no matter the filter applied to the room list.

Screenshots / GIFs

No ui change.

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added the PR-Misc For other changes label Jun 6, 2025
Copy link
Contributor

github-actions bot commented Jun 6, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UWQwi2

Copy link

sonarqubecloud bot commented Jun 6, 2025

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 38.09524% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (de194e0) to head (14c2325).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/libraries/matrix/impl/RustMatrixClient.kt 7.69% 24 Missing ⚠️
...libraries/matrix/impl/room/join/DefaultJoinRoom.kt 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4838      +/-   ##
===========================================
- Coverage    80.45%   80.44%   -0.01%     
===========================================
  Files         2140     2140              
  Lines        56773    56771       -2     
  Branches      7117     7118       +1     
===========================================
- Hits         45674    45672       -2     
- Misses        8664     8665       +1     
+ Partials      2435     2434       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ganfra ganfra marked this pull request as ready for review June 7, 2025 07:21
@ganfra ganfra requested a review from a team as a code owner June 7, 2025 07:21
@ganfra ganfra requested review from jmartinesp and removed request for a team June 7, 2025 07:21
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

// Ensure that the room is ready
.also { innerClient.awaitRoomRemoteEcho(it.roomId.value) }
.also { innerClient.awaitRoomRemoteEcho(roomId.value).destroy() }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new destroy here!

@bmarty bmarty merged commit a873e71 into develop Jun 9, 2025
36 of 39 checks passed
@bmarty bmarty deleted the feature/fga/room_info_flow_rework branch June 9, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants