-
Notifications
You must be signed in to change notification settings - Fork 237
misc (matrix) : use innerClient.subscribeToRoomInfo sdk method #4838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4838 +/- ##
===========================================
- Coverage 80.45% 80.44% -0.01%
===========================================
Files 2140 2140
Lines 56773 56771 -2
Branches 7117 7118 +1
===========================================
- Hits 45674 45672 -2
- Misses 8664 8665 +1
+ Partials 2435 2434 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
// Ensure that the room is ready | ||
.also { innerClient.awaitRoomRemoteEcho(it.roomId.value) } | ||
.also { innerClient.awaitRoomRemoteEcho(roomId.value).destroy() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new destroy
here!
Content
Rework how we manage the
client.roomInfoFlow
by using the newinnerClient.subscribeToRoomInfo
sdk method.Ensure we are using only
RoomInfo
and notRoomSummary
as those ones are bound to theRoomList
.Motivation and context
Makes sure we can observe
RoomInfo
for any room, either a known or unknown room, no matter the filter applied to the room list.Screenshots / GIFs
No ui change.
Tests
Tested devices
Checklist