Skip to content

fix (identity change) : RoomMemberIdentityStateChange in non encrypted room #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jun 4, 2025

Content

Makes sure we can configure the observation of RoomMemberIdentityStateChange in non encrypted room too.

It's useful to be able to display the verify user action from the RoomMember detail screen of a non encrypted room.

Added a bunch of tests.

Motivation and context

Handles second point of element-hq/element-meta#2810 (comment)

Screenshots / GIFs

Tests

  • Open a non encrypted room
  • Click on a non verified user avatar
  • Open the profile
  • You should see the "verify user" action

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

…IdentityStateChange in non encrypted room if needed
@ganfra ganfra added the PR-Bugfix For bug fix label Jun 4, 2025
@ganfra ganfra marked this pull request as ready for review June 4, 2025 20:31
@ganfra ganfra requested a review from a team as a code owner June 4, 2025 20:31
@ganfra ganfra requested review from bmarty and removed request for a team June 4, 2025 20:31
Copy link
Contributor

github-actions bot commented Jun 4, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/n3KG94

Copy link

sonarqubecloud bot commented Jun 4, 2025

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (1ca2e9b) to head (e664e24).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4824   +/-   ##
========================================
  Coverage    80.46%   80.46%           
========================================
  Files         2141     2141           
  Lines        56737    56735    -2     
  Branches      7110     7111    +1     
========================================
  Hits         45652    45652           
  Misses        8637     8637           
+ Partials      2448     2446    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ganfra ganfra merged commit 800a331 into develop Jun 5, 2025
35 of 36 checks passed
@ganfra ganfra deleted the feature/fga/fix_identity_change branch June 5, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants