Add extra logs the 'send call notification' flow #4819
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4819 +/- ##
===========================================
- Coverage 80.40% 80.38% -0.02%
===========================================
Files 2149 2149
Lines 56843 56874 +31
Branches 7125 7127 +2
===========================================
+ Hits 45703 45718 +15
- Misses 8689 8706 +17
+ Partials 2451 2450 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -181,6 +181,9 @@ class DefaultActiveCallManager @Inject constructor( | |||
| Timber.tag(tag).w("Call type $callType does not match the active call type, ignoring") | |||
| return | |||
| } | |||
|
|
|||
| Timber.tag(tag).d("Hung up call: $callType") | |||
There was a problem hiding this comment.
Is there some sensitive information in callType? Maybe safer to shrink some data first?
There was a problem hiding this comment.
I don't think there's anything there that won't be logged at some other point (URL in webview or session id + room id for room calls).
There was a problem hiding this comment.
I added some changes to prevent the URL from being logged.
This can happen, but according to @manuroe in his case it's intermittent, so I don't think it's related. Either that or some user in that room was adding and verifying/signing out sessions non-stop 😅 . |
|
Also we have #4756, so 🤷♂️ |
I think that may be a bit stale. Most of the logs in this PR would still be valuable even if we remove the code to send the call notification (knowing when the call has started, when we receive an incoming call, when we hang up, the type of call, etc.). |
This change reduced if from 12 per call to 4 while testing it. Since we suspect race conditions may be related to sending the notify event not working, this should help.
|
Content
Add some extra logs for the 'send call notification' flow when starting a call.
Motivation and context
It's been observed the notify call event is not always sent. This should help debug why.
Checklist