Skip to content

Rename classes overriding classes from the FFI layer. #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 4, 2025

Content

Rename classes overriding classes from the FFI layer, and ensure that the convention is followed with a new Konsist test

Motivation and context

Code consistency

Screenshots / GIFs

NA

Tests

  • NA

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner June 4, 2025 08:00
@bmarty bmarty requested review from jmartinesp and removed request for a team June 4, 2025 08:00
@bmarty bmarty added the PR-Misc For other changes label Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pFuntX

Copy link

sonarqubecloud bot commented Jun 4, 2025

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (efdc10e) to head (7cfc487).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4817   +/-   ##
========================================
  Coverage    80.39%   80.39%           
========================================
  Files         2149     2149           
  Lines        56838    56838           
  Branches      7126     7126           
========================================
  Hits         45697    45697           
  Misses        8690     8690           
  Partials      2451     2451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 390e5cf into develop Jun 4, 2025
30 of 31 checks passed
@bmarty bmarty deleted the feature/bma/renameFakeFfiClasses branch June 4, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants