Skip to content

Oidc: Fallback to external browser instead of using Webview #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 3, 2025

Content

Stop using Webview for Oidc when custom chrome tab is not available. Use a web browser instead.

Motivation and context

Replacement for #4293

Screenshots / GIFs

Tests

  • Can be tested without touching the code by doing a sign in, and when in the custom chrome tab, click the menu button and select "Open in [Chrome/Firefox/...] browser"
  • You can also test the reset identity flow.

Tested on my side, also the cancel flow, where the user kill the browser task and navigate back to the app. After 5 seconds, the continue button get enabled again as expected.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner June 3, 2025 09:51
@bmarty bmarty requested review from ganfra and removed request for a team June 3, 2025 09:51
@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Change For updates to an existing feature labels Jun 3, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 3, 2025
Copy link
Contributor

github-actions bot commented Jun 3, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7j3F2G

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (0953789) to head (7f09216).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4808      +/-   ##
===========================================
+ Coverage    80.40%   80.46%   +0.05%     
===========================================
  Files         2149     2140       -9     
  Lines        56843    56725     -118     
  Branches      7125     7108      -17     
===========================================
- Hits         45703    45642      -61     
+ Misses        8689     8636      -53     
+ Partials      2451     2447       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty force-pushed the feature/bma/oidcFallback branch from 5612376 to 7f09216 Compare June 4, 2025 14:13
@bmarty bmarty enabled auto-merge (squash) June 4, 2025 14:13
Copy link

sonarqubecloud bot commented Jun 4, 2025

@bmarty bmarty merged commit 36c7c7a into develop Jun 4, 2025
30 of 31 checks passed
@bmarty bmarty deleted the feature/bma/oidcFallback branch June 4, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants