Skip to content

Use Localazy's langAliases for Indonesian language #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented May 30, 2025

Content

Instead of manually moving all the values-id to values-in in some post-processing, this instructs the CLI to already download them in the right folders.

Motivation and context

This way we can remove the 'move all translations' step in the download strings script. I was looking at something else when I noticed this option for the Localazy CLI tool.

Tests

I tested this locally with ./tools/localazy/downloadStrings.sh --all and it worked as expected.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

This way we can remove the 'move all translations' stop in the download strings script.
@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label May 30, 2025
@jmartinesp jmartinesp requested a review from a team as a code owner May 30, 2025 08:08
@jmartinesp jmartinesp requested review from bmarty and removed request for a team May 30, 2025 08:08
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1ANkCb

Copy link

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (7e4b1ea) to head (2f91cdb).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4801   +/-   ##
========================================
  Coverage    80.43%   80.43%           
========================================
  Files         2143     2143           
  Lines        56769    56769           
  Branches      7120     7120           
========================================
  Hits         45660    45660           
  Misses        8672     8672           
  Partials      2437     2437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is removing some fairly long steps!

@jmartinesp jmartinesp merged commit d5b97ed into develop Jun 2, 2025
38 of 39 checks passed
@jmartinesp jmartinesp deleted the ci/use-lang-alias-instead-of-moving-translations branch June 2, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants