Skip to content

fix: exclude more domains from being backed up by the system #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

lucasmz-dev
Copy link
Contributor

tries* to fix #3465

Content

A simple change to exclude more domains in the backup rules xml configs

Motivation and context

Attempt to fix #3465

Tests

  • I didn't :(

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@lucasmz-dev lucasmz-dev requested a review from a team as a code owner May 25, 2025 11:13
@lucasmz-dev lucasmz-dev requested review from bmarty and removed request for a team May 25, 2025 11:13
@CLAassistant
Copy link

CLAassistant commented May 25, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 25, 2025
Copy link
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@lucasmz-dev lucasmz-dev force-pushed the fix-backups branch 3 times, most recently from 12d442d to 5479ee0 Compare May 27, 2025 17:53
@lucasmz-dev
Copy link
Contributor Author

For context, this is the same as the "regular" Element does:

https://github.com/element-hq/element-android/blob/develop/vector-app/src/main/res/xml/data_extraction_rules.xml

@bmarty bmarty added the PR-Bugfix For bug fix label Jun 2, 2025
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (7e4b1ea) to head (690a0cf).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4773      +/-   ##
===========================================
- Coverage    80.43%   80.42%   -0.01%     
===========================================
  Files         2143     2143              
  Lines        56769    56769              
  Branches      7120     7120              
===========================================
- Hits         45660    45657       -3     
  Misses        8672     8672              
- Partials      2437     2440       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit df62dd1 into element-hq:develop Jun 2, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element X allows device-to-device transfers, but doesn't result in a usable setup anyway
3 participants