Skip to content

fix(deps): update dependency androidx.compose:compose-bom to v2025.04.01 #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 3, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 23, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
androidx.compose:compose-bom 2025.04.00 -> 2025.04.01 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Apr 23, 2025
@renovate renovate bot requested a review from a team as a code owner April 23, 2025 20:02
@renovate renovate bot requested review from ganfra and removed request for a team April 23, 2025 20:02
@jmartinesp
Copy link
Member

This BOM version brings Compose 1.8.0 and that breaks lots of things, including our custom bottom sheet for the message composer. I can take a look if you want me to @ganfra .

@ganfra
Copy link
Member

ganfra commented Apr 24, 2025

This BOM version brings Compose 1.8.0 and that breaks lots of things, including our custom bottom sheet for the message composer. I can take a look if you want me to @ganfra .

Yes please if you have time 👍

Copy link
Contributor

github-actions bot commented Apr 24, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bnPkyy

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 24, 2025
@jmartinesp jmartinesp self-assigned this Apr 24, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 24, 2025
@@ -18,7 +18,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.invisibleToUser
import androidx.compose.ui.semantics.hideFromAccessibility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new name makes more sense!

Copy link
Contributor Author

renovate bot commented Apr 24, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jmartinesp jmartinesp force-pushed the renovate/compose.bom branch from 8a8be2d to 903646a Compare April 24, 2025 14:21
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.39%. Comparing base (b59ddeb) to head (f3aec47).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...in/impl/screens/loginpassword/LoginPasswordView.kt 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4631      +/-   ##
===========================================
+ Coverage    80.37%   80.39%   +0.02%     
===========================================
  Files         2149     2149              
  Lines        56855    56833      -22     
  Branches      7128     7131       +3     
===========================================
- Hits         45696    45693       -3     
+ Misses        8713     8693      -20     
- Partials      2446     2447       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@jmartinesp
Copy link
Member

If we merge this, we should also revert the workaround added for #3414

@jmartinesp
Copy link
Member

Moving this to draft until the issue with clicking components with Outline.Generic in Robolectric UI tests is fixed: robolectric/robolectric#9595

The modal bottom sheet (and other rounded corner components) used rounded corner shapes where one or more of its corners weren't rounded. These were previously translated to Outline.RoundedCorner with those corners having radius 0, now they're translated to Outline.Generic with a custom path (maybe for performance reasons?) the problem is the path.op(path2, Intersect) operation never worked on Robolectric since it's not implemented in the ShadowPath class, which previously wasn't an issue but now it clearly is...

@jmartinesp jmartinesp marked this pull request as draft April 25, 2025 09:48
@bmarty bmarty mentioned this pull request May 13, 2025
1 task
@bmarty bmarty force-pushed the renovate/compose.bom branch from 6a7c2e3 to cec524d Compare June 3, 2025 15:47
@bmarty
Copy link
Member

bmarty commented Jun 3, 2025

I have rebased the branch and added a commit, let me know if it's OK for you @jmartinesp , then I think we can merge the PR.

@bmarty bmarty marked this pull request as ready for review June 3, 2025 15:48
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I know that there is now a version 2025.05.00, but I guess we can let Renovate create a new PR with this upgrade.

@bmarty bmarty enabled auto-merge (squash) June 3, 2025 20:40
Copy link

sonarqubecloud bot commented Jun 3, 2025

@ElementBot
Copy link
Collaborator

Warnings
⚠️

gradle/libs.versions.toml#L23 - A newer version of androidx.compose:compose-bom than 2025.04.01 is available: 2025.05.01

⚠️

gradle/libs.versions.toml#L40 - A newer version of io.coil-kt.coil3:coil-test than 3.1.0 is available: 3.2.0

⚠️

gradle/libs.versions.toml#L42 - A newer version of com.bumble.appyx:testing-junit4 than 1.7.0 is available: 1.7.1

⚠️

gradle/libs.versions.toml#L45 - A newer version of me.saket.telephoto:zoomable-image-coil than 0.15.1 is available: 0.16.0

⚠️

gradle/libs.versions.toml#L186 - A newer version of org.maplibre.gl:android-sdk than 11.8.8 is available: 11.9.0

⚠️

gradle/libs.versions.toml#L189 - The native library arm64-v8a/libopuscodec.so (from io.element.android:opusencoder:1.1.0) is not 16 KB aligned

⚠️

gradle/libs.versions.toml#L194 - A newer version of io.sentry:sentry-android than 8.12.0 is available: 8.13.2

Generated by 🚫 dangerJS against f3aec47

@bmarty bmarty merged commit 7bb1e24 into develop Jun 3, 2025
28 of 29 checks passed
@bmarty bmarty deleted the renovate/compose.bom branch June 3, 2025 21:05
jmartinesp added a commit that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants