-
Notifications
You must be signed in to change notification settings - Fork 237
fix(deps): update dependency androidx.compose:compose-bom to v2025.04.01 #4631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This BOM version brings Compose 1.8.0 and that breaks lots of things, including our custom bottom sheet for the message composer. I can take a look if you want me to @ganfra . |
Yes please if you have time 👍 |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
@@ -18,7 +18,7 @@ import androidx.compose.runtime.Composable | |||
import androidx.compose.ui.Alignment | |||
import androidx.compose.ui.Modifier | |||
import androidx.compose.ui.res.stringResource | |||
import androidx.compose.ui.semantics.invisibleToUser | |||
import androidx.compose.ui.semantics.hideFromAccessibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new name makes more sense!
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
8a8be2d
to
903646a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4631 +/- ##
===========================================
+ Coverage 80.37% 80.39% +0.02%
===========================================
Files 2149 2149
Lines 56855 56833 -22
Branches 7128 7131 +3
===========================================
- Hits 45696 45693 -3
+ Misses 8713 8693 -20
- Partials 2446 2447 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
If we merge this, we should also revert the workaround added for #3414 |
Moving this to draft until the issue with clicking components with The modal bottom sheet (and other rounded corner components) used rounded corner shapes where one or more of its corners weren't rounded. These were previously translated to |
It doesn't seem to be needed anymore 🎉
…ues/366255137 Add `LocalUiTestMode` composition local and helper functions.
6a7c2e3
to
cec524d
Compare
I have rebased the branch and added a commit, let me know if it's OK for you @jmartinesp , then I think we can merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I know that there is now a version 2025.05.00, but I guess we can let Renovate create a new PR with this upgrade.
|
|
This PR contains the following updates:
2025.04.00
->2025.04.01
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.