You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
📖
Sign-off not required, allow-list
Error Error
ENOENT: no such file or directory, open 'libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/preferences/Config.kt'
Error: ENOENT: no such file or directory, open 'libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/preferences/Config.kt'
at Object.openSync (node:fs:596:3)
at Object.readFileSync (node:fs:464:35)
at ./tools/danger/dangerfile.js:140:24
at Array.filter (<anonymous>)
at Object.<anonymous> (./tools/danger/dangerfile.js:139:76)
at Module._compile (node:internal/modules/cjs/loader:1364:14)
at requireFromString (/usr/src/danger/node_modules/require-from-string/index.js:28:4)
at /usr/src/danger/dist/runner/runners/inline.js:161:68
at step (/usr/src/danger/dist/runner/runners/inline.js:52:23)
at Object.next (/usr/src/danger/dist/runner/runners/inline.js:33:53)
📱 Scan the QR code below to install the build (arm64 only) for this PR.
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xYscAx
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Let Preference Composable use ListItem under the hood.
Motivation and context
Let the application globally follow the design.
(And preparatory work for #2912)
Screenshots / GIFs
See recorded once.
Tests
Tested devices
Checklist