Skip to content

Iterate on preference design - DRAFT - STILL FIXING REGRESSION #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 24, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Let Preference Composable use ListItem under the hood.

Motivation and context

Let the application globally follow the design.

(And preparatory work for #2912)

Screenshots / GIFs

See recorded once.

Tests

  • Navigate to the various preference screen and check that there is no issues.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@ElementBot
Copy link
Collaborator

ElementBot commented May 24, 2024

Fails
🚫

Danger failed to run ./tools/danger/dangerfile.js.

Warnings
⚠️

Please add a changelog. See instructions here

Messages
📖 This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
📖 Sign-off not required, allow-list

Error Error

ENOENT: no such file or directory, open 'libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/preferences/Config.kt'
Error: ENOENT: no such file or directory, open 'libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/preferences/Config.kt'
    at Object.openSync (node:fs:596:3)
    at Object.readFileSync (node:fs:464:35)
    at ./tools/danger/dangerfile.js:140:24
    at Array.filter (<anonymous>)
    at Object.<anonymous> (./tools/danger/dangerfile.js:139:76)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at requireFromString (/usr/src/danger/node_modules/require-from-string/index.js:28:4)
    at /usr/src/danger/dist/runner/runners/inline.js:161:68
    at step (/usr/src/danger/dist/runner/runners/inline.js:52:23)
    at Object.next (/usr/src/danger/dist/runner/runners/inline.js:33:53)

Dangerfile

------^

Generated by 🚫 dangerJS against 1935cd2

@bmarty bmarty force-pushed the feature/bma/iterateOnPreferenceDesign branch from e5dbef5 to 9f07601 Compare May 24, 2024 16:28
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 24, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 24, 2024
Copy link
Contributor

github-actions bot commented May 24, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xYscAx

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 27, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 27, 2024
@bmarty bmarty closed this May 27, 2024
@bmarty bmarty deleted the feature/bma/iterateOnPreferenceDesign branch May 27, 2024 07:55
@bmarty
Copy link
Member Author

bmarty commented May 27, 2024

Replaced by #2922 in attempt to fix issue in LFS files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants