Fdroid release script #2904
Fdroid release script #2904
Conversation
…s the link is too long.
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2904 +/- ##
========================================
Coverage 75.23% 75.23%
========================================
Files 1550 1550
Lines 36954 36954
Branches 7152 7152
========================================
Hits 27803 27803
Misses 5415 5415
Partials 3736 3736 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I haven't tested it but the code makes sense to me. Note there were some issues with reproducible builds, but I'm not sure if it's caused by the script, since it seems more likely than the 2 built apk sources were not in sync somehow.
| @@ -117,7 +117,7 @@ version=${version:-${versionCandidate}} | |||
| versionMajor=`echo ${version} | cut -d "." -f1` | |||
| versionMinor=`echo ${version} | cut -d "." -f2` | |||
| versionPatch=`echo ${version} | cut -d "." -f3` | |||
| nextPatchVersion=$((versionPatch + 2)) | |||
| nextPatchVersion=$((versionPatch + 1)) | |||
There was a problem hiding this comment.
I agree to change this, just curious about why.
There was a problem hiding this comment.
Since we do not really do hotfix release currently I always have to change the value manually. This is a temporary change, maybe one day I will revert it.
Iterate on the release script to build and sign APKs for F-Droid.
Test OK with this build: https://github.com/element-hq/element-x-android/actions/runs/9189098239
And generated APKs have been added to this release: https://github.com/element-hq/element-x-android/releases/tag/v0.4.13
The scripts also have some other change, see commit per commit for the details.
Closes #1418