Skip to content

Restore MarkdownTextInput contents #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented May 23, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Add a MarkdownTextInputStateSaver to keep its contents when going to a sub-screen and coming back to it (these are not drafts).
  • Also add default text flags for the MD composer.

Motivation and context

Fixes #2898.
Fixes #2896.

Screenshots / GIFs

md_restoration.mp4

Tests

  • Go to any room.
  • Type something in the message composer.
  • Open another screen (room info, other user's details, call, etc.).
  • The unfinished message should be there when you come back to the room screen.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

- Create a `MarkdownTextInputStateSaver` and use it to save and restore the text and selection.
@jmartinesp jmartinesp requested a review from a team as a code owner May 23, 2024 10:09
@jmartinesp jmartinesp requested review from bmarty and removed request for a team May 23, 2024 10:09
Copy link
Contributor

github-actions bot commented May 23, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/e3aP7u

@jmartinesp jmartinesp force-pushed the fix/jme/2898-restore-markdown-input-text branch from 8fa0bd4 to 813219d Compare May 23, 2024 10:29
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 23, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 74.18%. Comparing base (06d5376) to head (813219d).

Files Patch % Lines
...ries/textcomposer/model/MarkdownTextEditorState.kt 0.00% 17 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2902      +/-   ##
===========================================
- Coverage    74.21%   74.18%   -0.04%     
===========================================
  Files         1540     1540              
  Lines        36892    36911      +19     
  Branches      7149     7152       +3     
===========================================
+ Hits         27381    27382       +1     
- Misses        5779     5796      +17     
- Partials      3732     3733       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmartinesp jmartinesp merged commit 72ab632 into develop May 23, 2024
23 of 25 checks passed
@jmartinesp jmartinesp deleted the fix/jme/2898-restore-markdown-input-text branch May 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text composer is cleared when leaving timeline screen Text composer no longer auto-capitalises the first lettter
3 participants