-
Notifications
You must be signed in to change notification settings - Fork 238
Restore MarkdownTextInput contents #2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Create a `MarkdownTextInputStateSaver` and use it to save and restore the text and selection.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
8fa0bd4
to
813219d
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2902 +/- ##
===========================================
- Coverage 74.21% 74.18% -0.04%
===========================================
Files 1540 1540
Lines 36892 36911 +19
Branches 7149 7152 +3
===========================================
+ Hits 27381 27382 +1
- Misses 5779 5796 +17
- Partials 3732 3733 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Type of change
Content
MarkdownTextInputStateSaver
to keep its contents when going to a sub-screen and coming back to it (these are not drafts).Motivation and context
Fixes #2898.
Fixes #2896.
Screenshots / GIFs
md_restoration.mp4
Tests
Tested devices
Checklist