When linkifying HTML messages, give priority to explicit link tags

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• When linkification creates a new link from the HTML contents, remove it if it conflicts with an existing explicit link.

Motivation and context

Should fix #2291.

The method used for restoring URLSpans removed by the linkification process gave priority to the newly found links instead of the existing links the sender had explicitly set, which is wrong.

Also, it was especially hard to debug because the issue was focused in phone number being linkified and the detection of those phone numbers depend on the region code returned by the TelephonyManager service, which will vary from one device to another. It's a lot easier to spot with emails, i.e.

Tests

• From EW or some other client, send a message like [test me@matrix.org](https://example.com) or its HTML equivalent.
• From the app, open it. It should open https://example.com. Previously me@matrix.org would get linkified and replace the link to the website.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NrjZH7

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.30%. Comparing base (29723a6) to head (f3babf8).
Report is 1 commits behind head on develop.

Files	Patch %	Lines
...ctories/event/TimelineItemContentMessageFactory.kt	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2879      +/-   ##
===========================================
+ Coverage    74.27%   74.30%   +0.02%     
===========================================
  Files         1530     1530              
  Lines        36521    36524       +3     
  Branches      7053     7054       +1     
===========================================
+ Hits         27127    27140      +13     
+ Misses        5708     5698      -10     
  Partials      3686     3686              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[bmarty]

@jmartinesp I think this will fix the issue describe here: #2861 (comment), can you confirm please?

[jmartinesp]

One of them, at least. You'd still be able to send [https://matrix.org](https://some-evil-site.com) and it would open the URL, not the text.

So I guess for that one we'd still need to somehow check if the text and URL in the link are both URLs and if there is some mismatch between them, then display some piece of UI to confirm you want to open the link?

[bmarty]

OK, thanks.

Yes, I was talking about the issue: Actually, it seems that EXA is opening https://example.org/, which is a bug to also fix, but which is mitigating the problem.

Thanks.