Skip to content

Restore legacy shrinking configuration for AGP 8.4.x #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2024
Merged

Restore legacy shrinking configuration for AGP 8.4.x #2867

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c060300
Restore legacy shrinking configuration for AGP `8.4.x`
jmartinesp May 17, 2024
e01b9ad
Update gradle.properties wording
jmartinesp May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,6 @@ android.enableBuildConfigAsBytecode=true

# By default, the plugin applies itself to all subprojects, but we don't want that as it would cause issues with builds using local AARs
dependency.analysis.autoapply=false

# Disabled new R8 shrinking for local dependencies as it causes issues with release builds
android.disableMinifyLocalDependenciesForLibraries=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that the value is false, it would be more logical to have true, but https://developer.android.com/build/releases/gradle-plugin#library-classes-shrunk is not clear about it.

If it fixes the issue, that's fine!

Loading