Skip to content

Fix crash when creating an EncryptedFile in Android 6 #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented May 15, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Makes sure the parent directory of the secret key file used for encrypting the session data is created before we try to create the actual key file.

Motivation and context

Fixes #2846.

Tests

  • Do a clean install of the app on an Android 6 emulator. If it doesn't crash it's fixed.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 6

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner May 15, 2024 15:23
@jmartinesp jmartinesp requested review from ganfra and removed request for a team May 15, 2024 15:23
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zivfoj

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.99%. Comparing base (87bd3ee) to head (bec01d8).
Report is 2 commits behind head on develop.

Files Patch % Lines
...ies/sessionstorage/impl/di/SessionStorageModule.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2853      +/-   ##
===========================================
- Coverage    73.99%   73.99%   -0.01%     
===========================================
  Files         1531     1531              
  Lines        36526    36529       +3     
  Branches      7065     7066       +1     
===========================================
  Hits         27028    27028              
- Misses        5796     5799       +3     
  Partials      3702     3702              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 15, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) May 15, 2024 15:35
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 15, 2024
@jmartinesp jmartinesp merged commit 69d5b56 into develop May 15, 2024
19 of 21 checks passed
@jmartinesp jmartinesp deleted the fix/jme/2846-accessing-session-store-in-android-6 branch May 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to access session_database.key before it is created
2 participants