Skip to content

UX cleanup: reorder text composer actions #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented May 15, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : UX cleanup

Content

  • Rearranged the actions in the attachments menu next to the text composer.

Motivation and context

Closes #2803.

Screenshots / GIFs

Before After

Tests

  • Check the actions have the new order as in the screenshots.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner May 15, 2024 07:17
@jmartinesp jmartinesp requested review from ganfra and removed request for a team May 15, 2024 07:17
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PpaFbL

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 15, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.99%. Comparing base (4f74dd4) to head (d1fdabc).

Files Patch % Lines
...ges/impl/messagecomposer/AttachmentsBottomSheet.kt 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2847   +/-   ##
========================================
  Coverage    73.99%   73.99%           
========================================
  Files         1531     1531           
  Lines        36526    36526           
  Branches      7065     7065           
========================================
  Hits         27028    27028           
  Misses        5796     5796           
  Partials      3702     3702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit ef38535 into develop May 15, 2024
21 checks passed
@jmartinesp jmartinesp deleted the misc/jme/2803-cleanup-composer-menu branch May 15, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] UX cleanup: composer menu
2 participants