Fix localazy import #2832
Merged
Fix localazy import #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
commented
May 13, 2024
| @@ -27,6 +27,8 @@ def normalizeForResourceConfigurations(locale): | |||
| return "in" | |||
| case "zh_TW#Hant": | |||
| return "zh-rTW" | |||
| case "zh#Hans": | |||
| return "zh-rCN" | |||
There was a problem hiding this comment.
Localazy will import string for simplified Chinese in the folders values-zh, and not values-zh-rCN. I am not sure this need to match the value here.
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2832 +/- ##
========================================
Coverage 73.95% 73.95%
========================================
Files 1530 1530
Lines 36541 36541
Branches 7074 7074
========================================
Hits 27025 27025
Misses 5811 5811
Partials 3705 3705 ☔ View full report in Codecov by Sentry. |
ganfra
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Localazy sync was failing because of Python version not supporting
matchstructure. The first commit fixes this. I have updated the version every where Python is used, hopefully there will be no bad side effect on the other GA.The second commit ensure that the data for simplified Chinese are correct. I'll let the next Localazy sync run the script and update the generated file, to validate it's working as expected (it's OK locally).