-
Notifications
You must be signed in to change notification settings - Fork 238
Split Maestro CI flow in 2 jobs. #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This way, if the Maestro test fails for some runtime reason we don't have to build the APK again to re-test it.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2823 +/- ##
========================================
Coverage 73.93% 73.93%
========================================
Files 1528 1528
Lines 36467 36467
Branches 7053 7053
========================================
Hits 26961 26961
Misses 5811 5811
Partials 3695 3695 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is definitely a very good improvement for devx
Note urgent, but I am wondering if we could reuse the APK from the build.yml action. Not sure how to properly have the same ability to trigger a partial workflow when we want to trigger Maestro using a label or a worflow dispatch though. |
That's also my end goal here, but I think the complexity would skyrocket since we'd need few extra checks, something that triggers the flow if the artefact no longer exists, etc. |
Type of change
Content
Split the Maestro CI flow into 2 jobs.
Motivation and context
This way, if the Maestro tests fail for some runtime reason we don't have to build the APK (~10min) again to re-test it.
Tests
A 2nd run of this job ran here: https://github.com/element-hq/element-x-android/actions/runs/9013826868/job/24765945553.
Tested devices
Checklist