Skip to content

Split Maestro CI flow in 2 jobs. #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented May 9, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Split the Maestro CI flow into 2 jobs.

Motivation and context

This way, if the Maestro tests fail for some runtime reason we don't have to build the APK (~10min) again to re-test it.

Tests

  • The Maestro job should be restartable, independent from the 'Build APK' one.

A 2nd run of this job ran here: https://github.com/element-hq/element-x-android/actions/runs/9013826868/job/24765945553.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

jmartinesp added 4 commits May 9, 2024 08:32
This way, if the Maestro test fails for some runtime reason we don't have to build the APK again to re-test it.
@jmartinesp jmartinesp requested a review from a team as a code owner May 9, 2024 07:37
@jmartinesp jmartinesp requested review from bmarty and removed request for a team May 9, 2024 07:37
Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2MZppG

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.93%. Comparing base (4c1bd2d) to head (6dd19ac).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2823   +/-   ##
========================================
  Coverage    73.93%   73.93%           
========================================
  Files         1528     1528           
  Lines        36467    36467           
  Branches      7053     7053           
========================================
  Hits         26961    26961           
  Misses        5811     5811           
  Partials      3695     3695           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 0ed4109 into develop May 9, 2024
@jmartinesp jmartinesp deleted the misc/jme/split-maestro-ci-flow-in-2-jobs branch May 9, 2024 08:25
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is definitely a very good improvement for devx

@bmarty
Copy link
Member

bmarty commented May 13, 2024

Note urgent, but I am wondering if we could reuse the APK from the build.yml action. Not sure how to properly have the same ability to trigger a partial workflow when we want to trigger Maestro using a label or a worflow dispatch though.

@jmartinesp
Copy link
Member Author

That's also my end goal here, but I think the complexity would skyrocket since we'd need few extra checks, something that triggers the flow if the artefact no longer exists, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants