-
Notifications
You must be signed in to change notification settings - Fork 237
Mark room as fully read when user goes back to the room list. #2687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2687 +/- ##
========================================
Coverage 80.40% 80.40%
========================================
Files 2149 2150 +1
Lines 56843 56854 +11
Branches 7125 7127 +2
========================================
+ Hits 45703 45713 +10
- Misses 8689 8690 +1
Partials 2451 2451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
I'm running this patch and it doesn't seem to do anything for me |
@bmarty I think the inner room can be closed before calling the method... |
OK, closing this for now, we will revisit when the |
@bmarty Can you link the relevant open ticket for what's blocking this currently? |
a1e8c21
to
ae8abec
Compare
…he room list, to mark the room as read.
ae8abec
to
ba1776c
Compare
|
Type of change
Content
Send
m.fully_read
read marker once the user is going back to the room list.Second commit is just removing noise in the logs.
Motivation and context
Closes #2281
Screenshots / GIFs
Tests
Tested devices
Checklist