Skip to content

Add toggle to hide empty state in devtools #30352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 22, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jul 21, 2025

This is helpful for when shwoing m.rtc.member events. They are empty if the person is left. With this option we can easily filter for only non-empty events to save time to clean room state. (It is also helpful for any other task where we want to investigate the room state and are interested in only joined members / want to know if a member is joined)

Screenshot From 2025-07-21 13-03-05 Screenshot From 2025-07-21 13-02-55

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will be really convenient.

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2025

Personally not sure seeing half the state updates is helpful for most things, like only seeing space children added but not removed would be confusing and form half a view of reality, if anything maybe it should be per-room

@toger5
Copy link
Contributor Author

toger5 commented Jul 22, 2025

Personally not sure seeing half the state updates is helpful for most things, like only seeing space children added but not removed would be confusing and form half a view of reality, if anything maybe it should be per-room

This is about the state in the state list. So it does not effect state changes but only filters current state in the modal state key list.
(I might misunderstand your comment?)

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2025

Ah okay, my bad, I thought it augmented "Show hidden events" - my mistake for reviewing without caffeine

@toger5 toger5 force-pushed the toger5/devtools-hide-empty-state branch from b3aa9d5 to 41708ac Compare July 22, 2025 12:16
@toger5 toger5 enabled auto-merge July 22, 2025 12:27
@toger5 toger5 added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@toger5 toger5 added this pull request to the merge queue Jul 22, 2025
Merged via the queue into develop with commit cc2ee5e Jul 22, 2025
35 checks passed
@toger5 toger5 deleted the toger5/devtools-hide-empty-state branch July 22, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants