Skip to content

Add Playwright tests for settings toggles #30318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Add Playwright tests for settings toggles #30318

wants to merge 12 commits into from

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Jul 15, 2025 •
edited
Loading

Split out from #30169

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@Half-Shot Half-Shot added T-Enhancement T-Task Tasks for the team like planning and removed T-Enhancement labels Jul 15, 2025
@Half-Shot Half-Shot marked this pull request as ready for review July 15, 2025 14:38
@Half-Shot Half-Shot requested a review from a team as a code owner July 15, 2025 14:38
t3chguy
t3chguy reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get some axe assertions thrown in please

@Half-Shot Half-Shot requested a review from t3chguy July 22, 2025 10:04
@Half-Shot Half-Shot force-pushed the hs/update-toggles-to-use-consistent-style-playwright-only branch from 411de48 to 9745741 Compare July 22, 2025 10:20
@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2025

@Half-Shot this still looks very unhappy

@Half-Shot
Copy link
Member Author

I am having a font based nightmare it seems, will fix tomorrow 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @t3chguy