Move RoomListSearch to shared components #30275
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn the trivial TextualEvent into a shared component with a separate view model for element web. Args to view model will probably change to be more specific and VM typer needs abstracting out into an interface, but should give the general idea.
Because we used it anyway, we just cheated by getting it from the context
cherry pick edc5e87 from florianduros/storybook
for React 19 compat
There's no reason to use the react-webpack plugin just because our app is stuck on webpack, it just means we have vite as a dependency too.
…t' into florianduros/storybook-i18n # Conflicts: # yarn.lock
florianduros
force-pushed
the
florianduros/new-room-list/shared-search
branch
from
7a39c88 to
c548db0
Compare
florianduros
force-pushed
the
florianduros/new-room-list/shared-search
branch
from
c548db0 to
c171817
Compare
florianduros
force-pushed
the
florianduros/new-room-list/shared-search
branch
2 times, most recently
from
3c5e113 to
b1bd607
Compare
florianduros
force-pushed
the
florianduros/new-room-list/shared-search
branch
from
b1bd607 to
68b7b9f
Compare
florianduros
force-pushed
the
florianduros/new-room-list/shared-search
branch
from
68b7b9f to
0055714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP