Fix highlights in messages (or search results) breaking links #30264
+97
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq#17011 and fixes element-hq#29807, by running the linkifier that turns text into links before the highlighter that adds highlights to text.
github-actions
bot
added
the
Z-Community-PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17011 and #29807, by running the linkifier that turns text into links before the highlighter that adds highlights to text - that way, the highlighter cannot break a link by inserting extraneous tags.
BTW, this PR was made as part of a live stream! (: You can see the final demonstration of the bug having been fixed (and subsequently reproduced on develop) near the very end, at 4:12:10. (:
Checklist
public/exportedsymbols have accurate TSDoc documentation.