Skip to content

Widget: Don't allow un-encrypted to-device traffic if the room is encrypted (parity with rust widget driver) #30241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Widget: Don't allow un-encrypted to-device traffic if the room is encrypted (parity with rust widget driver) #30241

wants to merge 4 commits into from

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jul 2, 2025 •
edited
Loading

Depends on #30239

Parity with rust-sdk widget driver.
If the widget is an encrypted room we should only accept encrypted to-device traffic.
Default to encrypted in non-room widgets.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@BillCarsonFr BillCarsonFr changed the title Valere/widget/decide to device encryption based on room Widget: Only allow encrypted to-device traffic if the room is encrypted (parity with rust widget driver) Jul 2, 2025
@BillCarsonFr BillCarsonFr added the T-Task Tasks for the team like planning label Jul 2, 2025
@BillCarsonFr BillCarsonFr marked this pull request as ready for review July 4, 2025 08:15
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner July 4, 2025 08:15
@BillCarsonFr BillCarsonFr requested review from dbkr and MidhunSureshR and removed request for a team July 4, 2025 08:15
Base automatically changed from valere/widget/use_new_received_to_device_event to develop July 10, 2025 08:21
@BillCarsonFr BillCarsonFr requested a review from toger5 July 10, 2025 09:02
@toger5 toger5 changed the title Widget: Only allow encrypted to-device traffic if the room is encrypted (parity with rust widget driver) Widget: Don't allow un-encrypted to-device traffic if the room is encrypted (parity with rust widget driver) Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

@toger5 toger5 Awaiting requested review from toger5

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillCarsonFr @dbkr