-
Notifications
You must be signed in to change notification settings - Fork 119
Introduce configurable auto leave option #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: livekit
Are you sure you want to change the base?
Conversation
826db44
to
d4bca13
Compare
d4bca13
to
81864fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would have been easier to review if there was not a mix of refactoring to add an option object to the view model and mode the encryptionSystem in it as well as adding the new param.
This feature doesn't seem trivial for me and I see zero test to check what it is doing.
It looks to me that this as the potential to auto hangup on you, and I expect some test for the happy path as well as the edge cases. Maybe it will auto hangup on join at this point..
I put it out of review and back into draft since I also wanted the tests. |
👍 I followed a notification to review it. Good luck with the testing. BTW is it compatible with the Lobby? or it will only work when no lobby (asking because of the |
It will only happen in the call. Since we only have a running call view model once we join a call. I am not sure the |
This would be nice to be built on top of the UrlParam refactor pr but its still open to review since it does not really make a difference if we update this one with the changes of the refactor or if we update the rafactor to include the new params introduced here. |
If the call widget is started with the URL parameter:
telephoneAutoLeave
we want the call to automatically hangup when the other participants leaves. This PR implements this behavior.