Skip to content

Changing the video codec from VP8 to H.264 #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: livekit
Choose a base branch
from
Draft

Changing the video codec from VP8 to H.264 #3345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2f93d0c
fix docker image for lk-jwt-service to 0.2.3
fkwp Jun 10, 2025
80ebfca
addressing review comments. We now default to latest-ci build and for…
fkwp Jun 12, 2025
8b3af00
change video codec from vp8 to h264
fkwp Jun 18, 2025
717bd1c
add h264 specific presets and use them as simlucast layers
fkwp Jun 18, 2025
9a38c23
trying different resolutions
fkwp Jun 18, 2025
e74f168
trying different resolutions
fkwp Jun 18, 2025
790cd82
trying different resolutions
fkwp Jun 18, 2025
51b6d26
typo
fkwp Jun 18, 2025
9a83eb9
wip
fkwp Jun 18, 2025
045b8b1
wip
fkwp Jun 18, 2025
c2b7558
wip
fkwp Jun 18, 2025
4fa26a0
wip
fkwp Jun 18, 2025
f2e6e86
wip
fkwp Jun 18, 2025
dab1383
wip
fkwp Jun 18, 2025
ec99fc5
wip
fkwp Jun 18, 2025
6d78338
wip
fkwp Jun 18, 2025
dc26658
wip
fkwp Jun 19, 2025
0a18451
wip
fkwp Jun 19, 2025
64f5d46
Merge branch 'livekit' into fkwp/change_video_codec
fkwp Jun 19, 2025
af7ef0e
wip
fkwp Jun 19, 2025
2162383
debug livekit logging
fkwp Jun 19, 2025
d1aabde
Merge branch 'livekit' into fkwp/change_video_codec
fkwp Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/livekit/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,20 @@ import {
type RoomOptions,
ScreenSharePresets,
type TrackPublishDefaults,
type VideoPreset,
VideoPreset,
VideoPresets,
} from "livekit-client";

const VideoPresetsH264 = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what makes this specific H264 presets? Aren't those just regular presets that could also be used with other encordings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is in draft -- this is part of debugging why h264 with simulcast is not working on iOS devices.

using h264 specific presets help finding out if the h264 macro-block constraint is the problem here.

h144: new VideoPreset(256, 144, 155_000, 20),
h240: new VideoPreset(480, 234, 160_000, 20),
h176: new VideoPreset(320, 176, 160_000, 20),
h288: new VideoPreset(382, 288, 180_000, 20),
// h360: VideoPresets.h360,
h360: new VideoPreset(640, 360, 450_000, 20),
h540: new VideoPreset(960, 540, 800_000, 20),
} as const;

const defaultLiveKitPublishOptions: TrackPublishDefaults = {
audioPreset: AudioPresets.music,
dtx: true,
Expand All @@ -23,10 +33,13 @@ const defaultLiveKitPublishOptions: TrackPublishDefaults = {
red: false,
forceStereo: false,
simulcast: true,
videoSimulcastLayers: [VideoPresets.h180, VideoPresets.h360] as VideoPreset[],
videoSimulcastLayers: [
VideoPresetsH264.h144,
VideoPresets.h360,
Comment on lines +37 to +38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the mixture of VideoPresetsH264 and VideoPresets?

] as VideoPreset[],
screenShareEncoding: ScreenSharePresets.h1080fps30.encoding,
stopMicTrackOnMute: false,
videoCodec: "vp8",
videoCodec: "h264",
videoEncoding: VideoPresets.h720.encoding,
backupCodec: { codec: "vp8", encoding: VideoPresets.h720.encoding },
} as const;
Expand Down
2 changes: 1 addition & 1 deletion src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ window.setLKLogLevel = setLKLogLevel;
initRageshake().catch((e) => {
logger.error("Failed to initialize rageshake", e);
});
setLKLogLevel("info");
setLKLogLevel("debug");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose? or a left over of a dev setup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is part of debugging why h264 with simulcast is not working on iOS devices.

setLKLogExtension((level, msg, context) => {
// we pass a synthetic logger name of "livekit" to the rageshake to make it easier to read
global.mx_rage_logger.log(level, "livekit", msg, context);
Expand Down
Loading