Skip to content

Send notification events when starting a call #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 18, 2025
Merged

Send notification events when starting a call #3248

merged 10 commits into from
Jul 18, 2025

Conversation

robintown
Copy link
Member

Previously this has been the responsibility of the hosting application (Element Web / Element X), but I would like to move this responsibility to Element Call itself to make it even more lightweight to integrate Element Call into a widget-capable client.

Depends on matrix-org/matrix-js-sdk#4826

@toger5
Copy link
Contributor

toger5 commented May 14, 2025

I remember the idea being that this is part of the hosting application is that we can have different behaviours on mobile vs desktop and that we might introduce custom ui to send a ring/notify call.
A modal for instance asking you if you really want to ring LargeNumber of users. Or a notice, that you do not have the right to ring in this room.

@robintown
Copy link
Member Author

I think we would still have the opportunity to do that, as the widget here gets to decide the notification behavior at the point that it enters the session, and the hosting application can always give extra context to the widget about how it's being used (intent etc.) through the URL params

robintown and others added 2 commits July 18, 2025 11:50
Previously this has been the responsibility of the hosting application (Element Web / Element X), but I would like to move this responsibility to Element Call itself to make it even more lightweight to integrate Element Call into a widget-capable client.
@toger5 toger5 marked this pull request as ready for review July 18, 2025 11:30
@toger5 toger5 requested a review from a team as a code owner July 18, 2025 11:30
@toger5 toger5 requested a review from BillCarsonFr July 18, 2025 11:30
@toger5 toger5 added X-Blocked Cannot be merged due to external dependencies and removed X-Blocked Cannot be merged due to external dependencies labels Jul 18, 2025
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in pair-programming session

@toger5 toger5 removed the X-Blocked Cannot be merged due to external dependencies label Jul 18, 2025
@toger5 toger5 merged commit 0e0fba6 into livekit Jul 18, 2025
19 checks passed
@alexander-potemkin
Copy link

@robintown , @toger5 , thank you for that! Am I correct that this feature has to be enabled in the configs? If so - could you please, advice on how to enable it? And when it might be available in production?

@fkwp
Copy link
Contributor

fkwp commented Jul 23, 2025

@robintown , @toger5 , thank you for that! Am I correct that this feature has to be enabled in the configs? If so - could you please, advice on how to enable it? And when it might be available in production?

It needs to be passed as an URL parameter by the Messenger Apps. Its on the agenda next:

  • ship new EC release
  • get PRs in the messenger Apps
  • release the messenger Apps

@alexander-potemkin
Copy link

It needs to be passed as an URL parameter by the Messenger Apps. Its on the agenda next:

  • ship new EC release
  • get PRs in the messenger Apps
  • release the messenger Apps

Thank you! From what I recall, from the chat on matrix.org, Element X developers has been resistant to enable group call notifications - so there are chances that messenger just won't enable that (unless I'm missing something!).

If so, is there a possibility to regulate Element Call behavior via server side configs somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature Release note category. A PR that introduces a new user facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants