Update default power levels for room and encrypt rooms on creation #3184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/encrypt-spa-rooms-power-level-for-encryption-events
branch
from
16ce793 to
2749ae4
Compare
BillCarsonFr
approved these changes
Apr 14, 2025
|
After a large call test we noticed high server load. It has to be concluded if this is caused by the room encryption being enabled or the toDevice key distribution. |
|
Maybe we should only merge this once we changed it so reactions will only be send unencrypted. Otherwise we will rapidly create a large megolm session in large calls where ppl use reactions. |
toger5
added
X-Blocked
|
We do not want to merge this since it will impact all spa rooms (and make them heavier: full megolm session needed for each room to send reactions) Instead the following is planned: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is pulled out from: #3167
So we can decide if we really want it. Its mostly independent except that if we want room encryption event fallbacks this is needed.
For spa guest links we use rooms defined by EW so they should be encrypted already. So this is only for todevice (or room key) transport in the spa with rooms created in the spa.