Skip to content

add -Werror #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

add -Werror #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72eb97d
add -Werror
simonpintarelli Apr 17, 2025
0c62c97
add verbose install
simonpintarelli Apr 17, 2025
aaa91cc
add keep_werror spack config
simonpintarelli May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ if (NOT CMAKE_BUILD_TYPE)
endif()

if(${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU" OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror")
set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g -ggdb -DDEBUG")
set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-g -ggdb -O2")
elseif(${CMAKE_CXX_COMPILER_ID} STREQUAL "Intel")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")
set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g -DDEBUG")
set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-g -O2")
Expand Down
3 changes: 2 additions & 1 deletion ci/build-cpu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export SPACK_SYSTEM_CONFIG_PATH=/user-environment/config

# make sure we keep the stage direcorty
spack config --scope=user add config:build_stage:/dev/shm/spack-stage
spack config --scope=user add config:flags:keep_werror:all

spack env create -d ./spack-env
# add local repository with current sirius recipe
Expand All @@ -20,7 +21,7 @@ spack -e ./spack-env develop -p $PWD sirius@develop
cat ./spack-env/spack.yaml

spack -e ./spack-env concretize
spack -e ./spack-env install
spack -e ./spack-env install -v

# the tar pipe below expects a relative path
builddir=$(spack -e ./spack-env location -b sirius)
Expand Down
3 changes: 2 additions & 1 deletion ci/build-cuda.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export SPACK_SYSTEM_CONFIG_PATH=/user-environment/config

# make sure we keep the stage direcorty
spack config --scope=user add config:build_stage:/dev/shm/spack-stage
spack config --scope=user add config:flags:keep_werror:all

spack env create -d ./spack-env
# add local repository with current sirius recipe
Expand All @@ -22,7 +23,7 @@ spack -e ./spack-env develop -p $PWD sirius@develop
cat ./spack-env/spack.yaml

spack -e ./spack-env concretize
spack -e ./spack-env install
spack -e ./spack-env install -v

# the tar pipe below expects a relative path
builddir=$(spack -e ./spack-env location -b sirius)
Expand Down