-
Notifications
You must be signed in to change notification settings - Fork 175
New way of backporting #4887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New way of backporting #4887
Conversation
This pull request does not have a backport label. Could you fix it @ev1yehor? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool workflow, especially now that we're actively supporting multiple branches.
If I'm reading this correctly, we're adding the ability to use 'backport-active-', and yet still retaining the option to backport only to specific branches. If that's the case, then LGTM unless somebody else thinks of an edge case that I haven't considered.
@karenzone You are right. We can use backport-active-* labels to backport changes to active branches while you can still use old labels to specific branches. And If you want to backport changes to specific branch in future, you can always use |
List of active branches taken from json: https://storage.googleapis.com/artifacts-api/snapshots/branches.json |
Proposed commit message
New way of backporting to active branches using new github action.
Why
No need to support the hardcoded branches in the
.mergify.yml
file anymore.We use a dynamic approach by fetching https://storage.googleapis.com/artifacts-api/snapshots/branches.json and filtering the branches.
Issues
Already enabled in Elastic Agent: