Skip to content

[8.16](backport #4818) [AWS Firehose] Improve Firehose documentation #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2025

Description

Improves AWS Firehose documentation, aligning with the update done on AWS Firehose Integration documentation at elastic/integrations#12732

Further, updates all Firehose related documentations to have the same or similar recommended configurations.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • [] None of the above

Related issue

Related : elastic/integrations#12150
Related : #4784

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

This is an automatic backport of pull request #4818 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner February 27, 2025 20:58
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Feb 27, 2025
Copy link
Contributor Author

mergify bot commented Feb 27, 2025

Cherry-pick of 9813ea7 has failed:

On branch mergify/bp/8.16/pr-4818
Your branch is up to date with 'origin/8.16'.

You are currently cherry-picking commit 9813ea7c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/en/observability/cloud-monitoring/aws/ingest-aws-firehose.asciidoc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/en/observability/cloud-monitoring/aws/monitor-aws-cloudtrail-firehose.asciidoc
	both modified:   docs/en/observability/cloud-monitoring/aws/monitor-aws-cloudwatch-firehose.asciidoc
	both modified:   docs/en/observability/cloud-monitoring/aws/monitor-aws-firewall-firehose.asciidoc
	both modified:   docs/en/observability/cloud-monitoring/aws/monitor-aws-waf-firehose.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@Kavindu-Dodan Kavindu-Dodan self-requested a review February 28, 2025 14:54
@Kavindu-Dodan Kavindu-Dodan force-pushed the mergify/bp/8.16/pr-4818 branch 2 times, most recently from d52e832 to 9eecfed Compare February 28, 2025 15:03
* update firehose endpoint and data stream details

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

* improve api key and retry duration section

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

* fix wording of storage location

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

* improve further by modifying all related documents

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

* Update docs/en/observability/cloud-monitoring/aws/ingest-aws-firehose.asciidoc

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

---------

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
(cherry picked from commit 9813ea7)

# Conflicts:
#	docs/en/observability/cloud-monitoring/aws/monitor-aws-cloudtrail-firehose.asciidoc
#	docs/en/observability/cloud-monitoring/aws/monitor-aws-cloudwatch-firehose.asciidoc
#	docs/en/observability/cloud-monitoring/aws/monitor-aws-firewall-firehose.asciidoc
#	docs/en/observability/cloud-monitoring/aws/monitor-aws-waf-firehose.asciidoc
@Kavindu-Dodan Kavindu-Dodan force-pushed the mergify/bp/8.16/pr-4818 branch from 9eecfed to 087f8a4 Compare February 28, 2025 15:04
@Kavindu-Dodan Kavindu-Dodan requested review from alaudazzi and removed request for a team February 28, 2025 15:34
Copy link
Contributor Author

mergify bot commented Mar 3, 2025

This pull request has not been merged yet. Could you please review and merge it @Kavindu-Dodan? 🙏

Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kavindu-Dodan Kavindu-Dodan enabled auto-merge (squash) March 3, 2025 14:46
@Kavindu-Dodan Kavindu-Dodan merged commit c599843 into 8.16 Mar 3, 2025
5 checks passed
@Kavindu-Dodan Kavindu-Dodan deleted the mergify/bp/8.16/pr-4818 branch March 3, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants