Skip to content

mergify: support 8.18 backports #4810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2025
Merged

mergify: support 8.18 backports #4810

merged 3 commits into from
Mar 25, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 30, 2025

does what it says in the tin

@v1v v1v requested a review from reakaleek January 30, 2025 13:24
@v1v v1v requested a review from a team as a code owner January 30, 2025 13:24
@v1v v1v self-assigned this Jan 30, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 30, 2025
@v1v v1v changed the title mergify: support 8.18 backports mergify: support 8.18 and 9.0 backports Jan 30, 2025
lahsivjar
lahsivjar reviewed Mar 25, 2025
View reviewed changes
v1v
v1v commented Mar 25, 2025
View reviewed changes
lahsivjar
lahsivjar approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@v1v v1v changed the title mergify: support 8.18 and 9.0 backports mergify: support 8.18 backports Mar 25, 2025
@v1v v1v enabled auto-merge (squash) March 25, 2025 18:22
bmorelli25
bmorelli25 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@v1v v1v merged commit 9b029cd into main Mar 25, 2025
7 checks passed
@v1v v1v deleted the v1v-patch-1 branch March 25, 2025 19:20
@lahsivjar
Copy link
Contributor

lahsivjar commented Mar 26, 2025 •
edited
Loading

@v1v should this be backported to 8.x branch too?

Looks like it is not needed as I can see backports to 8.18 being created from 8.x branch

@v1v
Copy link
Member Author

v1v commented Mar 26, 2025 •
edited
Loading

Looks like it is not needed as I can see backports to 8.18 being created from 8.x branch

Changes in the mergify file should be on in the default branch. there is no need for backports :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahsivjar lahsivjar lahsivjar approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@reakaleek reakaleek Awaiting requested review from reakaleek

@colleenmcginnis colleenmcginnis Awaiting requested review from colleenmcginnis

Assignees

@v1v v1v

Labels
backport-skip Skip notification from the automated backport with mergify needs-writer-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @lahsivjar @bmorelli25