Skip to content

[Security Solution] remove editHighlightedFields feature flag #239047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −12
Draft

[Security Solution] remove editHighlightedFields feature flag #239047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions x-pack/solutions/security/plugins/security_solution/common/experimental_features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,6 @@ export const allowedExperimentalValues = Object.freeze({
*/
newExpandableFlyoutNavigationDisabled: false,

/**
* Enables the ability to edit highlighted fields in the alertflyout
*/
editHighlightedFields: true,

/**
* Enables CrowdStrike's RunScript RTR command
* Release: 8.18/9.0
Expand Down
2 changes: 1 addition & 1 deletion ...rity_solution/public/flyout/document_details/right/components/highlighted_fields.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('<HighlightedFields />', () => {
beforeEach(() => {
jest.clearAllMocks();
(useHighlightedFieldsPrivilege as jest.Mock).mockReturnValue({
isEditHighlightedFieldsDisabled: false,
isDisabled: false,
tooltipContent: 'tooltip content',
});
(useRuleIndexPattern as jest.Mock).mockReturnValue({
Expand Down
2 changes: 1 addition & 1 deletion .../security_solution/public/flyout/document_details/right/components/highlighted_fields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export interface HighlightedFieldsProps {
*/
showCellActions: boolean;
/**
* If true, the edit button will be shown on hover (granted that the editHighlightedFieldsEnabled is also turned on).
* If true, the edit button will be shown on hover.
* This is false by default (for the AI for SOC alert summary page) and will be true for the alerts page.
*/
showEditButton?: boolean;
Expand Down
2 changes: 1 addition & 1 deletion ...y_solution/public/flyout/document_details/right/components/investigation_section.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ describe('<InvestigationSection />', () => {
loading: false,
});
(useHighlightedFieldsPrivilege as jest.Mock).mockReturnValue({
isEditHighlightedFieldsDisabled: false,
isDisabled: false,
tooltipContent: 'tooltip content',
});

Expand Down
5 changes: 1 addition & 4 deletions ...curity_solution/public/flyout/document_details/right/components/investigation_section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import React, { memo } from 'react';
import { EuiSpacer } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import { useIsExperimentalFeatureEnabled } from '../../../../common/hooks/use_experimental_features';
import { useExpandSection } from '../hooks/use_expand_section';
import { ExpandableSection } from './expandable_section';
import { HighlightedFields } from './highlighted_fields';
Expand All @@ -32,8 +31,6 @@ export const InvestigationSection = memo(() => {

const expanded = useExpandSection({ title: KEY, defaultValue: true });

const editHighlightedFieldsEnabled = useIsExperimentalFeatureEnabled('editHighlightedFields');

return (
<ExpandableSection
expanded={expanded}
Expand All @@ -58,7 +55,7 @@ export const InvestigationSection = memo(() => {
investigationFields={investigationFields}
scopeId={scopeId}
showCellActions={true}
showEditButton={editHighlightedFieldsEnabled}
showEditButton={true}
ancestorsIndexName={ancestorIndex}
/>
</ExpandableSection>
Expand Down