Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion oas_docs/output/kibana.serverless.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9479,8 +9479,9 @@ paths:
example: 50
in: query
name: size
required: true
required: false
schema:
default: 50
minimum: 1
type: number
- description: Start of the time range for filtering generations. Accepts absolute timestamps (ISO 8601) or relative date math (e.g. "now-7d").
Expand Down
3 changes: 2 additions & 1 deletion oas_docs/output/kibana.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10315,8 +10315,9 @@ paths:
example: 50
in: query
name: size
required: true
required: false
schema:
default: 50
minimum: 1
type: number
- description: Start of the time range for filtering generations. Accepts absolute timestamps (ISO 8601) or relative date math (e.g. "now-7d").
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1428,8 +1428,9 @@ paths:
example: 50
in: query
name: size
required: true
required: false
schema:
default: 50
minimum: 1
type: number
- description: >-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1428,8 +1428,9 @@ paths:
example: 50
in: query
name: size
required: true
required: false
schema:
default: 50
minimum: 1
type: number
- description: >-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const GetAttackDiscoveryGenerationsRequestQuery = z.object({
/**
* The maximum number of generations to retrieve
*/
size: z.coerce.number().min(1),
size: z.coerce.number().min(1).optional().default(50),
/**
* Start of the time range for filtering generations. Accepts absolute timestamps (ISO 8601) or relative date math (e.g. "now-7d").
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ paths:
example: "now"
- name: size
in: query
required: true
required: false
schema:
type: number
minimum: 1
default: 50
description: The maximum number of generations to retrieve
example: 50
- name: start
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const getKibanaFeatureFlags = async (

const attackDiscoveryPublicApiEnabled = await featureFlags.getBooleanValue(
ATTACK_DISCOVERY_PUBLIC_API_ENABLED_FEATURE_FLAG,
false
true
);

return {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ const AlertSelectionQueryComponent: React.FC<Props> = ({
>
<EuiSuperDatePicker
commonlyUsedRanges={commonlyUsedRanges}
compressed={true}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before:

date_picker_before

after:

date_picker_after

data-test-subj="alertSelectionDatePicker"
end={settings.end}
isDisabled={false}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe('useKibanaFeatureFlags', () => {
});
});

it('calls getBooleanValue with the expected default value (false)', async () => {
it('calls getBooleanValue with the expected default value (true)', async () => {
mockGetBooleanValueFn.mockReturnValue(false);

renderHook(() => useKibanaFeatureFlags(), {
Expand All @@ -84,7 +84,7 @@ describe('useKibanaFeatureFlags', () => {
await waitFor(() => {
expect(mockGetBooleanValueFn).toHaveBeenCalledWith(
ATTACK_DISCOVERY_PUBLIC_API_ENABLED_FEATURE_FLAG,
false // <-- expected default when the feature flag is not configured
true // <-- expected default when the feature flag is not configured
);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const useKibanaFeatureFlags = (): UseKibanaFeatureFlags => {
} = useKibana();

const attackDiscoveryPublicApiEnabled = useMemo(
() => featureFlags.getBooleanValue(ATTACK_DISCOVERY_PUBLIC_API_ENABLED_FEATURE_FLAG, false),
() => featureFlags.getBooleanValue(ATTACK_DISCOVERY_PUBLIC_API_ENABLED_FEATURE_FLAG, true),
[featureFlags]
);

Expand Down