Skip to content

[Fleet] Adjust minimum % on auto-upgrade modal #239019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+44 −2
Open

[Fleet] Adjust minimum % on auto-upgrade modal #239019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
958d66d
changed min to be 1
Supplementing Oct 14, 2025
bc3ceb2
updated test cases and error string for zero percentage
Supplementing Oct 14, 2025
a2fbcde
Merge branch 'main' into fix-upgrade-modal-bound
elasticmachine Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions x-pack/platform/plugins/shared/fleet/common/services/agent_utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ export function checkTargetVersionsValidity(
if (versions.length !== uniqueVersions.size) {
return `duplicate versions not allowed`;
}
if (requiredVersions.some((item) => item.percentage < 1)) {
return `percentage must be greater than 0`;
}
if (requiredVersions.some((item) => !item.percentage)) {
return `percentage is required`;
}
Expand Down
2 changes: 1 addition & 1 deletion .../applications/fleet/sections/agents/components/manage_auto_upgrade_agents_modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ const TargetVersionsRow: React.FunctionComponent<{
onPercentageChange(newValue);
onUpdate(version, newValue);
}}
min={0}
min={1}
step={1}
max={100}
required
Expand Down
41 changes: 40 additions & 1 deletion ...ck/platform/plugins/shared/fleet/server/services/agent_policies/required_versions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,51 @@ describe('validateRequiredVersions', () => {
);
});

it('should throw error if percentage is 0 or undefined', () => {
it('should throw error if percentage is 0', () => {
expect(() => {
validateRequiredVersions('test policy', [
{ version: '9.0.0', percentage: 100 },
{ version: '9.1.0', percentage: 0 },
]);
}).toThrow(
new AgentPolicyInvalidError(
`Policy "test policy" failed required_versions validation: percentage must be greater than 0`
)
);
});

it('should throw error if percentage is less than 1', () => {
expect(() => {
validateRequiredVersions('test policy', [
{ version: '9.0.0', percentage: 100 },
{ version: '9.1.0', percentage: 0.5 },
]);
}).toThrow(
new AgentPolicyInvalidError(
`Policy "test policy" failed required_versions validation: percentage must be greater than 0`
)
);
});

it('should throw error if percentage is undefined', () => {
expect(() => {
validateRequiredVersions('test policy', [
{ version: '9.0.0', percentage: 100 },
{ version: '9.1.0', percentage: undefined as any },
]);
}).toThrow(
new AgentPolicyInvalidError(
`Policy "test policy" failed required_versions validation: percentage is required`
)
);
});

it('should throw error if percentage property is missing', () => {
expect(() => {
validateRequiredVersions('test policy', [
{ version: '9.0.0', percentage: 100 },
{ version: '9.1.0' } as any,
]);
}).toThrow(
new AgentPolicyInvalidError(
`Policy "test policy" failed required_versions validation: percentage is required`
Expand Down