[Metrics][Discover] Limit dimension selection to single dimension and optimize ESQL generation #239010
+83
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation - Changed MAX_DIMENSIONS_SELECTIONS from 10 to 1 in constants - Removed RENAME operation for single dimensions in ESQL query generation - Updated chart layers to use actual dimension name instead of DIMENSIONS_COLUMN for single dimensions - Modified dimensions selector to use singleSelection mode and updated UI messaging to singular - Updated all related tests to reflect single dimension behavior - Made singleSelection dynamic based on MAX_DIMENSIONS_SELECTIONS constant - Removed unused rename import from ESQL composer Prompts: - "I would like to limit the number of dimension the user can select to 1" - "I also like to modify the ESQL query that is generated to remove the RENAME for a single dimension" - "We also need to update useChartLayers to use just the dimension name when there is a single dimension specified instead of the DIMENSION_COLUMN" - "When the MAX_DIMENSION_SELECTIONS is greater than one, set the single selection to false" - "Can you update the test for create_esql_query" - "Can you check to see if there are tests for use_chart_layers and use_chart_layers_from_esql" 🤖 This commit was assisted by Cursor
simianhacker
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
💔 Build Failed
Failed CI StepsHistory |
…imensions-to-single-selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍒 Summary
Fixes #238878
🎙️ Prompts
🤖 This commit was assisted by Cursor