Skip to content

Remove deprecated 'php-http/message-factory' dependency #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

Bombaninha
Copy link
Contributor

Description:

This PR closes #1441

Removed the dependency on php-http/message-factory from the composer.json file.

This update is aligned with the ongoing trend of deprecating php-http/message-factory in favor of psr/http-factory to ensure compatibility with modern libraries and to avoid using deprecated components.

Evidence Collected from Other Package Changelogs:

  • nyholm/psr7

Make dependency on php-http/message-factory optional.

  • php-http/message

Removed dependency on php-http/message-factory as it is abandoned and this package does not actually use it.

  • php-http/discovery

Dropped php-http/message-factory from composer requirements as it is deprecated in favor of PSR-17.

  • php-http/mock-client

Removed dependency on php-http/message-factory as the mock client does not use it.

@Bombaninha Bombaninha requested a review from a team as a code owner April 2, 2025 01:08
@ezimuel ezimuel self-assigned this Apr 2, 2025
@ezimuel
Copy link
Contributor

ezimuel commented Apr 4, 2025

@Bombaninha thanks for your contribution. Can you rebase the PR? Thanks.

@Bombaninha
Copy link
Contributor Author

@Bombaninha thanks for your contribution. Can you rebase the PR? Thanks.

Hello, @ezimuel. Thanks for your feedback!
Do you have a target version for this change? I was thinking of keeping it in the latest (main).
Regarding the rebase onto main, I already get "up to date."

@ezimuel
Copy link
Contributor

ezimuel commented Apr 5, 2025

@Bombaninha you need to use main branch. Try to merge from main of the original repository (https://github.com/elastic/elasticsearch-php):

@Bombaninha Bombaninha force-pushed the remove-message-factory-dependency branch from 2689342 to e472904 Compare April 7, 2025 16:57
@Bombaninha
Copy link
Contributor Author

Done, @ezimuel.
Let me know if everything looks good or if there's anything else I should adjust.
Thanks!

Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ezimuel ezimuel merged commit 8feae88 into elastic:main Apr 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated php-http/message-factory is still in composer.json
2 participants