Skip to content

ActivityExtensions - Convert empty TraceId into empty string #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

ActivityExtensions - Convert empty TraceId into empty string #509

merged 1 commit into from
May 28, 2025

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented May 23, 2025 •
edited
Loading

Skips bonus compare, but just rely on the string-value of an "empty" activity (faster and more simple)

@github-actions GitHub Actions
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@snakefoot snakefoot force-pushed the ActivityExtensions branch 4 times, most recently from 8261470 to 3af5e9e Compare May 23, 2025 15:44
@snakefoot
Copy link
Contributor Author

@Mpdreamz Ready for review

@Mpdreamz
Copy link
Member

run docs-build

@Mpdreamz Mpdreamz merged commit 7bdef4e into elastic:main May 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @Mpdreamz