Skip to content

[Synthetics] Fix async step callback #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

[Synthetics] Fix async step callback #1042

merged 2 commits into from
Apr 7, 2025

Conversation

emilioalvap
Copy link
Contributor

Summary

Fix Synthetics step async declaration in provided examples.

Relates to elastic/observability-docs#4869

vigneshshanmugam
vigneshshanmugam approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, We have to do the same for serverless docs?

@emilioalvap
Copy link
Contributor Author

@vigneshshanmugam This change should apply for both. Afaict, the file is marked as stack and serverless

@vigneshshanmugam vigneshshanmugam enabled auto-merge (squash) April 7, 2025 18:27
@vigneshshanmugam vigneshshanmugam merged commit 367b8c5 into main Apr 7, 2025
3 of 4 checks passed
@vigneshshanmugam vigneshshanmugam deleted the synthetics-fix-steps branch April 7, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilioalvap @vigneshshanmugam