Skip to content

Conversation

@elamperti
Copy link
Owner

Summary

  • remove lodash hasIn in multiple modules
  • use optional chaining or 'in' operator

Testing

  • yarn test:unit
  • yarn typecheck

https://chatgpt.com/codex/tasks/task_e_685db9c32080832886ff644373983b2b

@elamperti elamperti force-pushed the codex/replace-lodash-get-and-hasin-calls branch from 2153f44 to ad0a444 Compare June 27, 2025 13:31
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 20.78%. Comparing base (677f6d1) to head (ad0a444).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/store/reducers/scrobbleReducer.ts 0.00% 3 Missing ⚠️
src/store/actions/userActions.js 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...discogs/transformers/tracksResponse.transformer.ts 97.61% <100.00%> (-0.06%) ⬇️
.../lastfm/transformers/tracksResponse.transformer.ts 96.15% <100.00%> (-0.15%) ⬇️
...astfm/transformers/userRecentTracks.transformer.ts 100.00% <100.00%> (ø)
src/store/actions/userActions.js 0.00% <0.00%> (ø)
src/store/reducers/scrobbleReducer.ts 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Jun 27, 2025

Open Scrobbler    Run #58

Run Properties:  status check passed Passed #58  •  git commit 782d8278cf ℹ️: Merge ad0a44431a4bbb3efa7913c94c0e19acf7bcb528 into 677f6d1ede7276b8993a077ed745...
Project Open Scrobbler
Branch Review codex/replace-lodash-get-and-hasin-calls
Run status status check passed Passed #58
Run duration 02m 44s
Commit git commit 782d8278cf ℹ️: Merge ad0a44431a4bbb3efa7913c94c0e19acf7bcb528 into 677f6d1ede7276b8993a077ed745...
Committer Enrico Lamperti
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

@elamperti elamperti merged commit 438979c into main Jun 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants