Skip to content

Conversation

@a7m-1st
Copy link
Collaborator

@a7m-1st a7m-1st commented Oct 24, 2025

Description

fixes - #573 is caused by "uvicorn" installation detection, thus triggering the whole uv cache clearing, npm installation etc...
possible cause for #488

Note:

@Wendong-Fan @nitpicker55555 according to the design it shouldn't have been triggered bcz its on separate channel all together from the main uv.

But generally I think after Wendong's fix to isolate, it should be stable. I.e. hopefully installation won't be triggered on runtime. What do you think?

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@a7m-1st a7m-1st self-assigned this Oct 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the detectInstallationLogs function and its usage to fix issues #573 and potentially #488, which were caused by uvicorn installation detection incorrectly triggering dependency installation processes (including uv cache clearing and npm installation). The fix eliminates the problematic runtime installation detection mechanism.

Key changes:

  • Removed detectInstallationLogs function from install-deps.ts
  • Removed import and call to detectInstallationLogs in init.ts
  • Removed associated test cases for the deleted functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
electron/main/install-deps.ts Removed the detectInstallationLogs function and related state variables that were causing false-positive installation triggers
electron/main/init.ts Removed the import and invocation of detectInstallationLogs from the backend startup flow
test/unit/electron/install-deps.test.ts Removed test cases for the now-deleted detectInstallationLogs functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants