Skip to content

Conversation

@FooFindBar
Copy link
Collaborator

@FooFindBar FooFindBar commented Oct 16, 2025

…red as "1."

Description

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

close #515

Copy link
Collaborator

@fengju0213 fengju0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix direction, but there's an issue:

The olPadding prop is used in src/components/WorkFlow/node.tsx (3 places with olPadding="pl-0"). Commenting out the ol component breaks this dynamic padding control.

Suggestion: Keep the ol component, just change list-inside to list-outside:

ol: ({ children }) => (
  <ol
    className={`list-decimal list-outside text-[13px] text-primary mb-2 ${olPadding}`}
    style={{ paddingLeft: olPadding || '1rem' }}
  >
    {children}
  </ol>
),

This fixes the numbering issue without breaking existing functionality.

@FooFindBar
Copy link
Collaborator Author

Good fix direction, but there's an issue:

The olPadding prop is used in src/components/WorkFlow/node.tsx (3 places with olPadding="pl-0"). Commenting out the ol component breaks this dynamic padding control.

Suggestion: Keep the ol component, just change list-inside to list-outside:

ol: ({ children }) => (
  <ol
    className={`list-decimal list-outside text-[13px] text-primary mb-2 ${olPadding}`}
    style={{ paddingLeft: olPadding || '1rem' }}
  >
    {children}
  </ol>
),

This fixes the numbering issue without breaking existing functionality.

image image

Thanks for the suggestion!
I tried using the text extracted from the image in the MarkDown component for testing, but the ordered list numbers were still disconnected.
That’s why I used the current approach to fix the issue.

@FooFindBar FooFindBar requested a review from fengju0213 October 16, 2025 09:59
@Pakchoioioi
Copy link
Contributor

Screenshot 2025-10-17 at 12 14 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Markdown ordered list always renders as 1.

5 participants