Skip to content

Add limitation in the array of events for the publish endpoint genera… #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ public class ProducerController {
@Value("${activedirectory.publish.enabled}")
private boolean isAuthenticationEnabled;

@Value("${maxSizeOfInputArray:250}")
private int maxSizeOfInputArray;

public void setMaxSizeOfInputArray(int maxSizeOfInputArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where the method is used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it

this.maxSizeOfInputArray = maxSizeOfInputArray;
}

private RestTemplate restTemplate = new RestTemplate();

private JsonParser parser = new JsonParser();
Expand Down Expand Up @@ -303,6 +310,14 @@ public ResponseEntity generateAndPublish(final String msgProtocol, final String
if (bodyJson.isJsonObject()) {
events.add(getAsJsonObject(bodyJson));
} else if (bodyJson.isJsonArray()) {
//here add check for limitation for events in array is fetched from REMReM property and checked during publishing.
if (bodyJson.getAsJsonArray().size() > maxSizeOfInputArray) {
return createResponseEntity(HttpStatus.BAD_REQUEST, JSON_ERROR_STATUS,
"The number of events in the input array is exceeded the allowed limit of 250 events. " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for generate, i.e. hard-coded value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"This issue occurred because the input array contains more than 250 events, which is not supported by the system. "
+ "To resolve this, please divide the events in to smaller arrays, ensuring each array contains no more than 250 events,"
+ "and try to publish them again. This limitation helps to maintain system performance and stability.");
}
for (JsonElement element : bodyJson.getAsJsonArray()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to call getAsJsonArray() multiple time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it

if (element.isJsonObject()) {
events.add(getAsJsonObject(element));
Expand Down
2 changes: 2 additions & 0 deletions publish-service/src/main/resources/application.properties
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,7 @@ activedirectory.connectionTimeOut:

spring.mvc.pathmatch.matching-strategy: ANT_PATH_MATCHER

#Maximum size of events in array is fetched from REMReM property and checked during publishing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for generate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

maxSizeOfInputArray: 250