Skip to content

Modified endpoint generateAndPublish to accept array of events #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 16, 2024
Merged

Modified endpoint generateAndPublish to accept array of events #294

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
65fc749
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Jun 10, 2024
0136d8b
Modified endpoint generate to accept array of events
shudhansu-shekhar Jun 19, 2024
14a5f7f
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Jul 11, 2024
2d55610
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Jul 16, 2024
04c79e6
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Jul 31, 2024
5566a4d
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Aug 1, 2024
7870507
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Aug 2, 2024
be8ff35
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Aug 5, 2024
6d9aca4
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Aug 8, 2024
1fdf99d
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Aug 14, 2024
4a596e3
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Aug 16, 2024
4c624e5
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Aug 16, 2024
acb0c70
Modified endpoint generateAndPublish to accept array of events
shudhansu-shekhar Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rvice/src/main/java/com/ericsson/eiffel/remrem/publish/controller/ProducerController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,12 @@
@ApiParam(value = "eiffel event", required = true) @RequestBody final String body) {
try {
JsonElement inputBody = JsonParser.parseString(body);
return send(msgProtocol, userDomain, tag, routingKey, inputBody);

Check warning

Code scanning / CodeQL

Information exposure through an error message Medium

Error information
Loading
can be exposed to an external user.
} catch (JsonSyntaxException e) {
String exceptionMessage = e.getMessage();
log.error("Unexpected exception caught due to parsed json data", exceptionMessage);
log.error("Cannot parse the following JSON data: " + body, exceptionMessage);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate the JSON data from the rest of logs:

... data:\n" + body + '\n'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

return createResponseEntity(HttpStatus.BAD_REQUEST, JSON_FATAL_STATUS,
"Invalid JSON parse data format due to: " + exceptionMessage);
"Invalid JSON data:" + exceptionMessage);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space missing after ':'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}
}

Expand Down Expand Up @@ -254,8 +254,8 @@

try {
JsonElement bodyJson = JsonParser.parseString(body);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should JSON parser be configured as in case of Generate service, i.e. not allowing duplicate keys, etc.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah can do this but why we need this here? Is it necessary if already there is check for correct event publishing means like incorrect event is not published on mb basically

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so we have the check in generator, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so we have the check in generator, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that duplicate key check we implement basically in generate

return generateAndPublish(msgProtocol, msgType, userDomain, tag, routingKey, parseData, failIfMultipleFound,
failIfNoneFound, lookupInExternalERs, lookupLimit, okToLeaveOutInvalidOptionalFields, bodyJson);
} catch (JsonSyntaxException e) {
String exceptionMessage = e.getMessage();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use exceptionMessage at line above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

log.error("Unexpected exception caught due to parsed json data", exceptionMessage);
Expand Down