Skip to content

Commit c0a0831

Browse files
tobiasakeemichaf
authored andcommitted
Removed Timeout parameter from subscripion code since the parameter will not be used. (#20)
1 parent 130f578 commit c0a0831

File tree

4 files changed

+5
-37
lines changed

4 files changed

+5
-37
lines changed

src/main/java/com/ericsson/ei/controller/model/Subscription.java

Lines changed: 3 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
"notificationType",
2424
"repeat",
2525
"requirements",
26-
"subscriptionName",
27-
"timeout"
26+
"subscriptionName"
2827
})
2928
public class Subscription {
3029

@@ -42,8 +41,6 @@ public class Subscription {
4241
private List<Requirement> requirements = new ArrayList<Requirement>();
4342
@JsonProperty("subscriptionName")
4443
private String subscriptionName;
45-
@JsonProperty("timeout")
46-
private Integer timeout;
4744
@JsonIgnore
4845
private Map<String, Object> additionalProperties = new HashMap<String, Object>();
4946

@@ -187,26 +184,6 @@ public void setSubscriptionName(String subscriptionName) {
187184
this.subscriptionName = subscriptionName;
188185
}
189186

190-
/**
191-
*
192-
* @return
193-
* The timeout
194-
*/
195-
@JsonProperty("timeout")
196-
public Integer getTimeout() {
197-
return timeout;
198-
}
199-
200-
/**
201-
*
202-
* @param timeout
203-
* The timeout
204-
*/
205-
@JsonProperty("timeout")
206-
public void setTimeout(Integer timeout) {
207-
this.timeout = timeout;
208-
}
209-
210187
@Override
211188
public String toString() {
212189
return ToStringBuilder.reflectionToString(this);
@@ -224,7 +201,7 @@ public void setAdditionalProperty(String name, Object value) {
224201

225202
@Override
226203
public int hashCode() {
227-
return new HashCodeBuilder().append(created).append(notificationMessage).append(notificationMeta).append(notificationType).append(repeat).append(requirements).append(subscriptionName).append(timeout).append(additionalProperties).toHashCode();
204+
return new HashCodeBuilder().append(created).append(notificationMessage).append(notificationMeta).append(notificationType).append(repeat).append(requirements).append(subscriptionName).append(additionalProperties).toHashCode();
228205
}
229206

230207
@Override
@@ -236,7 +213,7 @@ public boolean equals(Object other) {
236213
return false;
237214
}
238215
Subscription rhs = ((Subscription) other);
239-
return new EqualsBuilder().append(created, rhs.created).append(notificationMessage, rhs.notificationMessage).append(notificationMeta, rhs.notificationMeta).append(notificationType, rhs.notificationType).append(repeat, rhs.repeat).append(requirements, rhs.requirements).append(subscriptionName, rhs.subscriptionName).append(timeout, rhs.timeout).append(additionalProperties, rhs.additionalProperties).isEquals();
216+
return new EqualsBuilder().append(created, rhs.created).append(notificationMessage, rhs.notificationMessage).append(notificationMeta, rhs.notificationMeta).append(notificationType, rhs.notificationType).append(repeat, rhs.repeat).append(requirements, rhs.requirements).append(subscriptionName, rhs.subscriptionName).append(additionalProperties, rhs.additionalProperties).isEquals();
240217
}
241218

242219
}

src/main/resources/public/raml/common-schema.raml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ subscription: |
4444
},
4545
"subscriptionName":{
4646
"type":"string"
47-
},
48-
"timeout":{
49-
"type":"integer"
5047
}
5148
},
5249
"type":"object"
@@ -99,9 +96,6 @@ subscriptionList: |
9996
},
10097
"subscriptionName":{
10198
"type":"string"
102-
},
103-
"timeout":{
104-
"type":"integer"
10599
}
106100
},
107101
"type":"object"

src/test/resources/SubscriptionObject.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"subscriptionName": "Subscription_1",
33
"repeat": false,
44
"created": "data-time",
5-
"timeout": 12354,
65
"notificationType": "REST_POST",
76
"notificationMeta": "http://127.0.0.1:3000/ei/test_subscription_rest",
87
"notificationMessage": "@",

src/test/resources/subscription.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
"type" : "ARTIFACT_1"
2929
}
3030
],
31-
"subscriptionName" : "Subscription_Test",
32-
"timeout" : 12354
31+
"subscriptionName" : "Subscription_Test"
3332
},
3433
{
3534
"created" : "2017-07-27",
@@ -61,6 +60,5 @@
6160
"type" : "ARTIFACT_1"
6261
}
6362
],
64-
"subscriptionName" : "Subscription_Test_Modify",
65-
"timeout" : 12354
63+
"subscriptionName" : "Subscription_Test_Modify"
6664
}]

0 commit comments

Comments
 (0)